search

data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

fixed 8535Q #357

Closed WillLP-code closed 1 year ago

WillLP-code commented 1 year ago

Allowed children who died to not have a birth date

tab1tha commented 1 year ago

Oh apologies, I have read it again. The first part of the rule doesn't allow this. A child who died should have been born. We can't let it pass when the birthdate is missing. There might be something else causing the bug.

WillLP-code commented 1 year ago

Oh apologies, I have read it again. The first part of the rule doesn't allow this. A child who died should have been born. We can't let it pass when the birthdate is missing. There might be something else causing the bug.

@tab1tha Not true, not all pregnancies are carried fully to term. In these instances, the Expected DOB is after the date of death. Unless, as it's a query, we still want to flag this.

tab1tha commented 1 year ago

Oh apologies, I have read it again. The first part of the rule doesn't allow this. A child who died should have been born. We can't let it pass when the birthdate is missing. There might be something else causing the bug.

@tab1tha Not true, not all pregnancies are carried fully to term. In these instances, the Expected DOB is after the date of death. Unless, as it's a query, we still want to flag this.

There is another variable for unborn babies, ExpectedPersonBirthDate. This rule only interacts with PersonBirthDate which is for children who have been born. However, if you notice that the children who are wrongly flagged all have an ExpectedPersonBirthDate and no PersonBirthDate (i.e unborn), a filter can be added before the issue locations are returned. The filter should exclude any children in the list who have an ExpectedPersonBirthDate.

WillLP-code commented 1 year ago

Oh apologies, I have read it again. The first part of the rule doesn't allow this. A child who died should have been born. We can't let it pass when the birthdate is missing. There might be something else causing the bug.

@tab1tha Not true, not all pregnancies are carried fully to term. In these instances, the Expected DOB is after the date of death. Unless, as it's a query, we still want to flag this.

There is another variable for unborn babies, ExpectedPersonBirthDate. This rule only interacts with PersonBirthDate which is for children who have been born. However, if you notice that the children who are wrongly flagged all have an ExpectedPersonBirthDate and no PersonBirthDate (i.e unborn), a filter can be added before the issue locations are returned. The filter should exclude any children in the list who have an ExpectedPersonBirthDate.

They all have expected birth dates and no birth date meaning they died before they were born, so yes, I can add a filter for this and still keep the check for no birth date then