Closed SLornieCYC closed 1 year ago
Describe the bug Rule does not check DateOfInitialCPC in Section47.
DateOfInitialCPC
To Reproduce Steps to reproduce the problem, e.g.:
CINclosureDate
Expected behavior Section47 should be flagged as in-error from the later dated DateOfInitialCPC.
Proposed fix (Optional) I think condition1 here should be using DateOfInitialCPC_S47 rather than DateOfInitialCPC.
DateOfInitialCPC_S47
https://github.com/data-to-insight/CIN-validator/blob/dc4559d2362e0efacfe47ebb9b4b3d538c7d0094/cin_validator/rules/cin2022_23/rule_8565.py#L186
Describe the bug Rule does not check
DateOfInitialCPCin Section47.To Reproduce Steps to reproduce the problem, e.g.:
CINclosureDateand a Section47 with aDateOfInitialCPCafter theCINclosureDate.Expected behavior Section47 should be flagged as in-error from the later dated
DateOfInitialCPC.Proposed fix (Optional) I think condition1 here should be using
DateOfInitialCPC_S47rather thanDateOfInitialCPC.https://github.com/data-to-insight/CIN-validator/blob/dc4559d2362e0efacfe47ebb9b4b3d538c7d0094/cin_validator/rules/cin2022_23/rule_8565.py#L186