Describe the bug
Rule appears to not be filtering out Section47 records where ICPCnotRequired == 1. I know there was a recent issue (https://github.com/data-to-insight/CIN-validator/issues/318) and fix for ICPCnotRequired == "true" but this is about the 1/0 data.
Proposed fix (Optional)
I think the df_check here needs to use "1" (string) rather than 1 (int) to correctly match the data passed from the xml source?
Describe the bug Rule appears to not be filtering out Section47 records where
ICPCnotRequired== 1. I know there was a recent issue (https://github.com/data-to-insight/CIN-validator/issues/318) and fix forICPCnotRequired== "true" but this is about the 1/0 data.Proposed fix (Optional) I think the df_check here needs to use "1" (string) rather than 1 (int) to correctly match the data passed from the xml source?
https://github.com/data-to-insight/CIN-validator/blob/dc4559d2362e0efacfe47ebb9b4b3d538c7d0094/cin_validator/rules/cin2022_23/rule_8839.py#L47-L50