search

data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

Bugfix/ammened rules #412

Closed WillLP-code closed 1 year ago

WillLP-code commented 1 year ago

closes #381 closes #382 closes #383 Updates 2990, 8825Q, and 8873 to match updated DFE rules

tab1tha commented 1 year ago

Thanks Will.

The changes themselves are good to go. However, it is better to have these in the 2023-24 folder since they are part of that update.

SLornieCYC commented 1 year ago

Thanks Will.

The changes themselves are good to go. However, it is better to have these in the 2023-24 folder since they are part of that update.

These need to be in from 22-23 because the changes apply to the current year.

tab1tha commented 1 year ago

Is the current year 2022/2023 or 2023/2024? I ask because the validation rule updates that were released at the end of last year were tagged "2023/2024" @SLornieCYC ?

WillLP-code commented 1 year ago

I kept them in 22/23 as that's what Stephen wrote in the issue, happy to change them though!

SLornieCYC commented 1 year ago

Current year is 2022-23. i.e. data covering the period 1 April 2022 to 31 March 2023 (which DFE collect from us in a submission window between April 2023 to July 2023). The validation rule changes were included both in an update to the 2022-23 guidance (published October 2022) and the first version of the guides for 2023-24 (published November 2022) so apply equally to both.