search

data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

Bug: Python error when no errors found #416

Closed SLornieCYC closed 1 year ago

SLornieCYC commented 1 year ago

Describe the bug Loaded xml with one child-level rule selected, which is currently returning no errors. Page gets stuck on "Running analysis, this may take some time" (after leaving it for longer than it usually takes when all rules are selected!).

In the browser console there is a python error reported:

image

Proposed fix (Optional) I think the change made to cin_validator_class.py (https://github.com/data-to-insight/CIN-validator/pull/304/commits/33777b751c91a8bfd77fd3dcf6abee3c1feb0f35) here:

https://github.com/data-to-insight/CIN-validator/blob/0e392f0c8ca3668575e25d455acad74584450086/cin_validator/cin_validator_class.py#L80-L84

Needs following with a similar change here?

https://github.com/data-to-insight/CIN-validator/blob/0e392f0c8ca3668575e25d455acad74584450086/cin_validator/cin_validator_class.py#L130

tab1tha commented 1 year ago

This still happens image

tab1tha commented 1 year ago

Running python -m cin_validator run-all fake_data\fake_CIN_data.xml --select "100" replicates this bug in the command line.