search

data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

Bug: Rule 2889 - Errors not flagged in FE #430

Closed SLornieCYC closed 1 year ago

SLornieCYC commented 1 year ago

Describe the bug Some records are not being flagged as in-error when S47ActualStartDate is before CINreferralDate. Unsure whether this is a front-end issue as I can't see anything obviously wrong with the rule coding or tests? The records are flagged as errors in the DFE CIN portal.

Screenshots image

tab1tha commented 1 year ago

How about this one @SLornieCYC

SLornieCYC commented 1 year ago

Yep, this one seems to be working properly now too! Although the cell highlights on affected_fields don't seem to be working anymore (not just here, but for any rule on any client)?

tab1tha commented 1 year ago

Could you unpick that for me

  1. Is it that the light-blue colors on cells that have issues no longer appear?
  2. or that the deep blue cell color that you expect to appear when you click on the rule description no longer happens?
  3. or something else?
SLornieCYC commented 1 year ago

Could you unpick that for me

  1. Is it that the light-blue colors on cells that have issues no longer appear?
  2. or that the deep blue cell color that you expect to appear when you click on the rule description no longer happens?
  3. or something else?

Both 1 and 2! Example from a different rule:

image

This should have either UPN or UPNunknown in dark blue and the other in light blue.

tab1tha commented 1 year ago

Thank you. I'll give it a look

tab1tha commented 1 year ago

My version of the live tool shows the colors. Let's attempt a hard reload. In the browser tab where you have the tool open, could you

Do the colors come up now? If it doesn't, do tell me if it happens only on some children or all children.

SLornieCYC commented 1 year ago

Do the colors come up now? If it doesn't, do tell me if it happens only on some children or all children.

No colours after a hard refresh in the browser (firefox). Also tried a different browser (chrome) and no colours there either. Seems to affect all children. Also noticed that clicking on the errors in the list doesn't make the tables above jump to the error location (which I think it did before).

tab1tha commented 1 year ago

Sorry about that, @SLornieCYC We're not able to replicate the error on this end yet.
I asked @willLPD2I and he is able to see the blue colours too.

tab1tha commented 1 year ago

Update. We've succeeded to replicate the bug but haven't solved the behaviour yet. I've opened an issue page for it on the frontend repo https://github.com/data-to-insight/cin-validator-fe/issues/140

tab1tha commented 1 year ago

Update: The change that caused the colors to disappear has been reverted so that the tool can remain useful in the meantime. The side effect is that it deactivated the feature that allowed tables to have multiple rows. We are working on restoring that feature as soon as possible.