search

data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

Bug: Working day rules can't connect to SSL in FE #447

Closed SLornieCYC closed 1 year ago

SLornieCYC commented 1 year ago

Describe the bug Rules using the govuk_bank_holidays module for working days calculations aren't working in FE.

image

tab1tha commented 1 year ago

Thank you, I'll check this out.

If you have a chance, do check if 8775Q is now flagging errors like it is supposed to. We have addressed all the possible leaks, that we could find, of data between the backend and frontend.

tab1tha commented 1 year ago

This seems to be a problem in the pyodide part However, this thread https://github.com/pyodide/pyodide/issues/529 says that it should be resolved in version 0.2.0 and the error still comes up eventhough we're using version 0.2.1.

I'll keep looking.

tab1tha commented 1 year ago

Updating pyodide to the latest version (0.23.2) doesn't fix this.

tab1tha commented 1 year ago

Way forward is to pull the holiday dates from a static file that should be updated as part of the yearly ruleset update process.