Rule 8867 : CIN episode is shown as closed, however Assessment is not shown as completed

[tab1tha]

If \<CINclosureDate> (N00102) is present then all instances of the \<Assessments> group must include the \<AssesssmentAuthorisationDate> (N00160)

[GBurrel]

Hi @tab1tha - not able to get this to work. I've printed the data throughout the process and it seems to be producing what I expect but I still get an Assertion Error.

[tab1tha]

Hi @GBurrel, I'll give it a look as soon as I can.

[tab1tha]

Hi Gavin,

Unlike type 1 rules, push_type2 and push_tylpe3 create a list of objects. So, to evaluate an issue object, we'll need to get it out of the list. I noticed that it is not rule_8867 that fails but rule_4004 (did you write this one too?. There might be a mix-up in the branches. Run "git status" in the command line to see the files that you have changed in your branch.)

Fix: Do "issues_list = result.type3_issues" and "issues = issues_list[0]" to get the issues object of the first thing you pushed using push_type3 in your validate function. In this case, it is the issue object created from the failing locations in the CINplanDates table.

Then you can go ahead to do "issue_table = issues.table" and the other checks.

Side note: You can push the code as a pull request even if it is not working yet. That way, it is easier for me to see where it is failing. Could you do that?

[GBurrel]

Hi @tab1tha - I've made the amends for the type3 rules and created the Pull request so you should now be able to view the code. I ran the 'git status' command and got 'Your branch is up to date with 'origin/Rule8867'. nothing to commit, working tree clean' so I'm not sure about rule_4004. I'm sure I've not created that one...

[WillLP-code]

Hi Both,

Sorry I haven’t responded, I’ve been away on a course.

So, as far as it helps, the version on 4004 on main was buggy for a while, but I went in and fixed it last week some time, probably after Gavin made his branch.

Gavin, to update to the working 4004, you’ll need to run: ‘git merge origin/main’ in the terminal and accept incoming changes. If that doesn’t work, let Tambe and me know.

Cheers,

William Levack-Payne (He/Him) Data Advocate (Data to Insight) Children’s Services

07732 824391 | @.**@.>

From: Tambe Tabitha Achere @.> Sent: 24 November 2022 14:06 To: data-to-insight/CIN-validator @.> Cc: Subscribed @.***> Subject: Re: [data-to-insight/CIN-validator] Rule 8867 : CIN episode is shown as closed, however Assessment is not shown as completed (Issue #47)

Hi Gavin,

Unlike type 1 rules, push_type2 and push_tylpe3 create a list of objects. So, to evaluate an issue object, we'll need to get it out of the list. I noticed that it is not rule_8867 that fails but rule_4004 (did you write this one too?. There might be a mix-up in the branches. Run "git status" in the command line to see the files that you have changed in your branch.)

Fix: Do "issues_list = result.type3_issues" and "issues = issues_list[0]" to get the issues object of the first thing you pushed using push_type3 in your validate function. In this case, it is the issue object created from the failing locations in the CINplanDates table.

Then you can go ahead to do "issue_table = issues.table" and the other checks.

Side note: You can push the code as a pull request even if it is not working yet. That way, it is easier for me to see where it is failing. Could you do that?

Best Regards, Tambe

From: GBurrel @.<mailto:@.>> Sent: 23 November 2022 11:14 To: data-to-insight/CIN-validator @.<mailto:@.>> Cc: Tambe Tabitha @.<mailto:@.>>; Mention @.<mailto:@.>> Subject: Re: [data-to-insight/CIN-validator] Rule 8867 : CIN episode is shown as closed, however Assessment is not shown as completed (Issue #47)

Hi @tab1thahttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftab1tha&data=05%7C01%7Ctambe.tabitha%40socialfinance.org.uk%7Cfb80ea0c68a641cc804f08dacd43e06d%7C9c85420c07ed40e79c4c4207556dc906%7C0%7C0%7C638047988665360798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Qih%2BnWaR9IzJWPX%2BUwY1fo98QShahfFy9eo9huw71oM%3D&reserved=0 - not able to get this to work. I've printed the data throughout the process and it seems to be producing what I expect but I still get an Assertion Error.

- Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdata-to-insight%2FCIN-validator%2Fissues%2F47%23issuecomment-1324893996&data=05%7C01%7Ctambe.tabitha%40socialfinance.org.uk%7Cfb80ea0c68a641cc804f08dacd43e06d%7C9c85420c07ed40e79c4c4207556dc906%7C0%7C0%7C638047988665360798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=yhgW1G0Qj3gcFbx596kHhyRRCTj3wRvIfpomH98vLWk%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKB2JLKLVIL7SSPNNO5RAUDWJX4A5ANCNFSM53X2UEUQ&data=05%7C01%7Ctambe.tabitha%40socialfinance.org.uk%7Cfb80ea0c68a641cc804f08dacd43e06d%7C9c85420c07ed40e79c4c4207556dc906%7C0%7C0%7C638047988665360798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EkGmNmqprs13FPzqot%2B20VQbkXhxFxpHoOhwBNhqfyE%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.<mailto:@.>>

Tambe Tabitha

020 7770 6836 |

[Social Finance Logo]

87 Vauxhall Walk, London, SE11 5HJ [map]https://goo.gl/maps/ZARP7b3RvDENTQLp9

www.socialfinance.org.ukhttp://www.socialfinance.org.uk/<http://www.socialfinance.org.uk%3chttp:/www.socialfinance.org.uk/> | Twitterhttps://twitter.com/socfinuk | LinkedInhttps://www.linkedin.com/company/social-finance | Sign up to our newsletterhttp://www.socialfinance.org.uk/newsletter

This email and any attachments are confidential and may be subject to legal privilege. Any use, copying or disclosure other than by the intended recipient is unauthorised. If you have received this message in error, please notify the sender immediately via +44 (0) 20 7770 6836 and delete this message and any copies from your computer and network. The views expressed in this email are those of the author and do not necessarily reflect the views of Social Finance. Social Finance Limited is a not-for-profit private limited company registered in England and Wales with company number 6402143. Social Finance Limited is Authorised & Regulated by the Financial Conduct Authority FCA Number 497568.

— Reply to this email directly, view it on GitHubhttps://github.com/data-to-insight/CIN-validator/issues/47#issuecomment-1326499590, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZ57424EEGSVTTS2SXDHE5LWJ5Y53ANCNFSM53X2UEUQ. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>> This message is intended for the use of the addressee only and may contain confidential or privileged information. If you have received it in error please notify the sender and destroy it. You may not use it or copy it to anyone else.

E-mail is not a secure communications medium. Please be aware of this when replying. All communications sent to or from the County Council may be subject to recording and/or monitoring in accordance with relevant legislation.

Although East Sussex County Council has taken steps to ensure that this e-mail and any attachments are virus free, we can take no responsibility if a virus is actually present and you are advised to ensure that the appropriate checks are made.

You can visit our website at https://www.eastsussex.gov.uk

[GBurrel]

Hi @willLPD2I and @tab1tha - not sure if I created 4004 (although it's not impossible). I managed to create a Pull request for Rule8867 so that should be done. Do I still need to do something with 4004?

[WillLP-code]

You shouldn’t need to do anything with 4004, don’t worry!

William Levack-Payne (He/Him) Data Advocate (Data to Insight) Children’s Services

07732 824391 | @.**@.>

From: GBurrel @.> Sent: 25 November 2022 10:11 To: data-to-insight/CIN-validator @.> Cc: William Levack-Payne @.>; Mention @.> Subject: Re: [data-to-insight/CIN-validator] Rule 8867 : CIN episode is shown as closed, however Assessment is not shown as completed (Issue #47)

Hi @willLPD2Ihttps://github.com/willLPD2I and @tab1thahttps://github.com/tab1tha - not sure if I created 4004 (although it's not impossible). I managed to create a Pull request for Rule8867 so that should be done. Do I still need to do something with 4004?

— Reply to this email directly, view it on GitHubhttps://github.com/data-to-insight/CIN-validator/issues/47#issuecomment-1327281596, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZ57422ZMUAI774YSN76CV3WKCGD5ANCNFSM53X2UEUQ. You are receiving this because you were mentioned.Message ID: @.**@.>> This message is intended for the use of the addressee only and may contain confidential or privileged information. If you have received it in error please notify the sender and destroy it. You may not use it or copy it to anyone else.

E-mail is not a secure communications medium. Please be aware of this when replying. All communications sent to or from the County Council may be subject to recording and/or monitoring in accordance with relevant legislation.

Although East Sussex County Council has taken steps to ensure that this e-mail and any attachments are virus free, we can take no responsibility if a virus is actually present and you are advised to ensure that the appropriate checks are made.

You can visit our website at https://www.eastsussex.gov.uk

[GBurrel]

Hi @willLPD2I and @tab1tha - is this one complete now and can be merged?

[tab1tha]

Hi Gavin, yes it is.

[GBurrel]

Thanks @tab1tha - just trying to identify some more to do 😁

[tab1tha]

When you run this does it work? It produces an assertion error on my end. I've scheduled a deep dive into the logic, for myself, later today. @GBurrel

[GBurrel]

Hi @tab1tha - I'm getting an Assertion Error as well. To be honest I'm not sure if that was as far as I could get as I do seem to mention Assertion Errors in my first messages above.

[tab1tha]

No worries. I'll sort it out.