search

data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

Adds Sex to ChildIdentifiers table in api and ingress, adds sample rule to test #472

Closed WillLP-code closed 11 months ago

WillLP-code commented 1 year ago

closes #468 #469

Adds (in addition to keeping ) to both the api and ingress.

This works because when building the tables, if a child block has no , it'll leave it as a pd.NA, and the same for . This is a much easier fix than checking the return year sent from the FE and changing the ingress based on this.

Caveat: the way the rules list builds means that any rules which check to see isn't empty carried over from previous years need to be updated and added to the 24/25 ruleset using so that errors aren't thrown for them. This would be the case even if the ingress was done by checking the return year anyway, and this way, until that's all done, we get errors thrown by the validator, not thrown by Python when it can't find columns.

SO: every rule with needs to be updated and added to 24/25 using (and the new gender codes). This will be a separate PR once this is merged.

Also, adds 2886Q as a proof of concept and an updated XML so that the run command in the CLI can be used for 24/25.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (864115e) 93.06% compared to head (bbcd81b) 93.08%. Report is 5 commits behind head on main.

Files Patch % Lines
cin_validator/__main__.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #472 +/- ## ========================================== + Coverage 93.06% 93.08% +0.01% ========================================== Files 123 123 Lines 5088 5087 -1 ========================================== Hits 4735 4735 + Misses 353 352 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.