data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

Bug: Rule 8535Q - does not flag unborns #478

Closed SLornieCYC closed 2 months ago

SLornieCYC commented 2 months ago

Describe the bug Rule does not trigger when client record has a DOD but no DOB. Looks like this was changed in https://github.com/data-to-insight/csc-validator-be-cin/pull/357 however the previous logic was correct. There is a specific bypass for this query in the DFE portal for unborns.

8535Q: All records have been checked and can confirm that the data has been amended (where required). All remaining queries relate to pregnancies that did not proceed to full term or the child died before or during birth.

Expected behavior If client has a DOD and no DOB this should be flagged as in-error.

Proposed fix Reinstate the original code from before https://github.com/data-to-insight/csc-validator-be-cin/pull/357. Note that the commit/PR cannot be reverted in its entirety because there are appear to be other changes included.