Make appropriate considerations for PyProxy memory leaks

data-to-insight / quality-lac-data-beta

Quality LAC data Beta project

MIT License

8 stars 3 forks source link

Make appropriate considerations for PyProxy memory leaks #34

Open mwaddoups opened 3 years ago

mwaddoups commented 3 years ago

There are ongoing issues with Pyodide where accessing Python objects from Javascript can cause them to not be garbage collected when they go out of scope.

I need to double check what the impacts of this are for us. But to summarize

When we call toJs it creates many PyProxys (particularly on deep objects)
These are not (!) automatically GC'ed and must be destroyed manually.

A fix may be coming for this in a later version of Pyodide - but for now, we should definitely fix it.

mwaddoups commented 2 years ago

This is actually fixed in the recently upgraded to 0.18 version - they improved this substantially so it shouldn't be a problem