search

data-to-insight / quality-lac-data-beta

Quality LAC data Beta project
MIT License
8 stars 3 forks source link

Sort order for Child IDs #49

Open SLornieCYC opened 3 years ago

SLornieCYC commented 3 years ago

Child ID should be sorted when provided in lists - e.g. the filter list in-browser and for the csv export.

mwaddoups commented 3 years ago

What is a sensible sorting for this?

I wasn't sure if it was best to sort them numerically, or by number of errors descending, or keep the original sorting of the export - what do you think?

SLornieCYC commented 2 years ago

Good point! I'd thought initially alphanumerically by ID would be most logical as that way even through multiple re-loads the data will always be presented in the same order. It can be frustrating if you're trying to work through record by record and each time you look they turn up in a different order.

I've only tried using the fake data files so far and thought the ordering might be arbitrary/random from the process of loading data in. If it's based on the source file that is probably alright as (I imagine) in most cases the file will already be ordered.

Sorting by errors might be interesting although arguably that could be skewed by cases where one /actual/ error triggers half a dozen inter-related error codes (vs other records with multiple discrete errors each only flagged once). Maybe it would be better dealt with via sort handles on the list in-browser?

mwaddoups commented 2 years ago

These are really good ideas!

I think I agree with you - for a first step I will put in alphanumeric sorting just for that repeatability, then I will look into options for other sorting. I can see it being a pain just having to scroll to find the children with the worst errors.

mwaddoups commented 2 years ago

I have added the alphanumeric sorting now.