search

data-to-insight / quality-lac-data-beta

Quality LAC data Beta project
MIT License
8 stars 3 forks source link

Load postcodes as soon as dashboard is displayed #63

Closed kws closed 2 years ago

kws commented 2 years ago

I'm not quite sure why the PC file was cached in indexed db, so have removed this. It can be easily re-instated, but for beta testing let's keep things simple.

kws commented 2 years ago

@dezog I haven't got any sample files just now, but this looks like it works from basic testing. Any chance you could do the "offline" testing and see if it still works?

dezog commented 2 years ago

awesome, cheers @kws! going to spend tomorrow on frontend so I'll test this out before I add the other changes we talked about

dezog commented 2 years ago

Hey @kws, so I just tried this locally with some fake data and this happened - seems to be to do with how pyodide translates objects between the Python & JS?

image

Might be that the 'Dexie' thing was a workaround for this issue? I'll leave this for now as it's not vital to have sorted ahead of testing, but will have a look next week.

kws commented 2 years ago

@dezog sorry - I think it was my fault - I missed the fact that the data was passed as an ArrayBuffer rather than a Blob. That should now be fixed.

dezog commented 2 years ago

sweet, cheers Kaj I'll try it now