reduce 5-min timeslots from 292 to 52 (save 140 rows) - Githubissues

data-umbrella / event-board-web

Event Board: front-end code

https://events.dataumbrella.org

GNU Affero General Public License v3.0

10 stars 13 forks source link

reduce 5-min timeslots from 292 to 52 (save 140 rows) #344

Closed reshamas closed 1 year ago

reshamas commented 1 year ago

PR Overview

Type of contribution

[x] Code
[ ] Documentation

Reference: Issue or Pull Request (PR)

[x] Towards #334 [this will keep reference issue or PR open] <=== When in doubt, pick this one.
[ ] Fixes #xxx. See also #xxx. [this will close the referenced issue or PR]
[ ] Resolves #xxx, #xxx [for multiple issues, this will close them]

Ticket Description

reduce 5-min timeslots to 30-min timeslots
from 292 to 52 (save 140 rows)

Description of Changes

File: https://github.com/data-umbrella/event-board-web/blob/main/src/constants/time-slots.js

Before and After for UI Updates

<-- You should have 2 images minimum, for desktop, 4 for mobile and desktop combined -->

Before:

After:

For PR Reviewer

[ ] Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
[ ] If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
[ ] Does this file match the related tickets linked figma file, or does it pass the visual smell test?
[ ] If this file contains javascript, does the javascript pass the smell test?
[ ] If you don't feel super confident in your review, did you assign someone more senior to double check?

NOTE FOR REVIEWER

I wasn't able to test the sign-in page because I didn't have the backend running.