data-umbrella / event-board-web

Event Board: front-end code
https://events.dataumbrella.org
GNU Affero General Public License v3.0
10 stars 13 forks source link

set default price to {empty} #357

Closed reshamas closed 1 year ago

reshamas commented 1 year ago

PR Overview

Type of contribution

Reference: Issue or Pull Request (PR)

Description of Changes

<-- Brief description of the changes you made, files you touched, etc -->

Before and After for UI Updates

<-- You should have 2 images minimum, for desktop, 4 for mobile and desktop combined -->

Before:

Screen Shot 2023-01-19 at 2 04 31 PM

After:

Screen Shot 2023-01-19 at 2 04 12 PM

For PR Reviewer

jtorreggiani commented 1 year ago

@reshamas, do we want to default to paid or just not render anything if we don't have a value?

reshamas commented 1 year ago

@reshamas, do we want to default to paid or just not render anything if we don't have a value?

We should default to < blank > if "paid" or "free" is not in the data

jtorreggiani commented 1 year ago

This was resolved as part of another PR. Closing to keep the pull requests update to date.