Fix featured events filter - Githubissues

data-umbrella / event-board-web

Event Board: front-end code

https://events.dataumbrella.org

GNU Affero General Public License v3.0

10 stars 13 forks source link

Fix featured events filter #407

Closed jtorreggiani closed 1 year ago

jtorreggiani commented 1 year ago

PR Overview

Fixes an issue with unpublished events showing up in the featured events feed.

Type of contribution

[X] Code
[ ] Documentation

Reference: Issue or Pull Request (PR)

[ ] Towards #xxx

Description of Changes

<-- Brief description of the changes you made, files you touched, etc --> Just needed to add the publish = true parameter to the API request.

Before and After for UI Updates

The only visible difference is that unpublished events won't show up.

For PR Reviewer

[X] Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
[X] If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
[X] Does this file match the related tickets linked figma file, or does it pass the visual smell test?
[X] If this file contains javascript, does the javascript pass the smell test?
[X] If you don't feel super confident in your review, did you assign someone more senior to double check?