update contributing instructions - Githubissues

data-umbrella / event-board-web

Event Board: front-end code

https://events.dataumbrella.org

GNU Affero General Public License v3.0

10 stars 13 forks source link

update contributing instructions #421

Closed reshamas closed 11 months ago

reshamas commented 11 months ago

PR Overview

Type of contribution

[ ] Code
[x] Documentation

Reference: Issue or Pull Request (PR)

[ ] Towards #xxx

Description of Changes

<-- Brief description of the changes you made, files you touched, etc -->

Before and After for UI Updates

<-- You should have 2 images minimum, for desktop, 4 for mobile and desktop combined -->

Before:

After:

For PR Reviewer

[ ] Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
[ ] If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
[ ] Does this file match the related tickets linked figma file, or does it pass the visual smell test?
[ ] If this file contains javascript, does the javascript pass the smell test?
[ ] If you don't feel super confident in your review, did you assign someone more senior to double check?