search

data-upstream / data-upstream-service-201902

0 stars 0 forks source link

Fixing Specs #7

Open data-upstream opened 5 years ago

data-upstream commented 5 years ago

@Yihang I already upgraded the app to Factory-Bot wich is new and replaces Factory-Girl. (it is only actually a renaming).

When I run the spec ./bin/bundle exec rspec spec/controllers/log_data_controller_spec.rb

the following include is missing. include Api::V1::Concerns::Sessions

Alvin, Yihang, could you take a quick look?

alvinvoo commented 5 years ago

Hi @afitterling ,

I think the upgrade to Factory-Bot has break the rails runtime, now running 'rails s' will give

NoMethodError: undefined method 'key_rotation_enabled' in 'device' factory method_missing at /home/alvinvoo/.rbenv/versions/jruby-9.2.5.0/lib/ruby/gems/shared/gems/factory_bot-5.0.0/lib/factory_bot/definition_proxy.rb:97 ..

NoMethodError: undefined method 'key' in 'system_config' factory method_missing at /home/alvinvoo/.rbenv/versions/jruby-9.2.5.0/lib/ruby/gems/shared/gems/factory_bot-5.0.0/lib/factory_bot/definition_proxy.rb:97

etc

I am not familiar with factory girl nor factory bot, are these fixtures?

afitterling commented 5 years ago

oh. yes these are trst fixtures. could you rewind my commit?

afitterling commented 5 years ago

sorry for that. The Malay government told me yesterday i must leave the country i am in thailand now. i will come back in 7 days

afitterling commented 5 years ago

but thailand is my second home!

alvinvoo commented 5 years ago

oh. yes these are trst fixtures. could you rewind my commit?

Alright Alex, enjoy your stay in Thailand ;) I will study the gems, see if I could resolve this. Else, I will rewind your commit.

afitterling commented 5 years ago

dear Alvin i entered a thai temple for a couple days. we talk when i am back... it looks great. i am cutoff internet some time. come back to you. dockerization is good!

Alexander Fitterling Mettlenweg 28 2504 Biel/Bienne Switzerland Tel.: +41 (0)768045101

Am 14.02.2019 um 12:31 schrieb Alvin Voo notifications@github.com:

oh. yes these are trst fixtures. could you rewind my commit?

Alright Alex, enjoy your stay in Thailand ;) I will study the gems, see if I could resolve this. Else, I will rewind your commit.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.