search

data2health / DREAM-Challenge

EHR DREAM Challenge
7 stars 2 forks source link

Review of the challenge data curation script #18

Closed trberg closed 4 years ago

trberg commented 5 years ago

Jupyter notebook describing the curation of the data: https://github.com/data2health/DREAM-Challenge/tree/master/documentation

tschaffter commented 5 years ago

@trberg Do we already have a document that describes the curation protocol?

tschaffter commented 5 years ago

Need to be reviewed by:

tschaffter commented 5 years ago

I should be able to review this documentation today or tomorrow.

@yy6linda Can you please carefully review the Jupyter notebooks that Tim wrote to refined the datasets? This is a critical step to prevent the risk of having bugs affecting the curated data.

yy6linda commented 5 years ago

Sure, will do.

On Tue, Jun 4, 2019 at 12:03 AM Thomas Schaffter notifications@github.com wrote:

I should be able to review this documentation today or tomorrow.

@yy6linda https://github.com/yy6linda Can you please carefully review the Jupyter notebooks that Tim wrote to refined the datasets? This is a critical step to prevent the risk of having bugs affecting the curated data.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/data2health/DREAM-Challenge/issues/18?email_source=notifications&email_token=AJLO2D652MNTWRQ42YNJ5FDPYU5TLA5CNFSM4HMG2UMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZ3X7A#issuecomment-498318332, or mute the thread https://github.com/notifications/unsubscribe-auth/AJLO2D5S4AXQCQ337VDXZIDPYU5TLANCNFSM4HMG2UMA .

yy6linda commented 5 years ago

I can't run the code directly to validate it because I don't have access to the database. @trberg Shall we find a time to meet and go over the code on your machine.

tschaffter commented 5 years ago

@yy6linda Have you and @trberg met to review together the content of the curation script? Since we are still in the process of finalizing the preparation of the challenge data, I would recommend that you meet again to review the finalized script. This script should be then uploaded to Synapse staging and its location mentioned in the document where we describe the preparation of the data.

yy6linda commented 5 years ago

Not yet, but I will talk to Tim