BUG: 7.8.1 does the wrong thing for `iati-organisation`s

data4development / IATI-Rulesets

Various conditional and restraint rules for IATI data

MIT License

0 stars 4 forks source link

BUG: 7.8.1 does the wrong thing for `iati-organisation`s #59

Closed andylolz closed 4 years ago

andylolz commented 5 years ago

https://github.com/data4development/IATI-Rulesets/blob/04edd05d1b6f897e686b99f13342dfce584f99f9/rules/iati/financial.xslt#L52-L59

The template match clause doesn’t specify an iati-activity, but the check for a default-currency does. So iati-organisations with a default-currency fall foul of this rule.

andylolz commented 4 years ago

Confirmed elsewhere by @rolfkleef that this is a bug. I’ve amended the title accordingly.

andylolz commented 4 years ago

I guess this is fixed in d9606a358c6184edd2e2c19380762d1e8f080a88, and can be closed now?

rolfkleef commented 4 years ago

thanks @andylolz!