search

data4development / IATI-data-validator

GNU Affero General Public License v3.0
5 stars 6 forks source link

Error 7.8.1 shown despite valid `iati-organisation/@default-currency` #43

Closed andylolz closed 4 years ago

andylolz commented 4 years ago

Describe the bug

I’m seeing Error 7.8.1:

The Value must have a specified Currency, or the Activity must have a default Currency.

…for an org file that includes a valid iati-organisation/@default-currency.

To Reproduce Steps to reproduce the behavior:

  1. Go here
  2. See error:

    The Value must have a specified Currency, or the Activity must have a default Currency.

  3. Note that the dataset in question is an org file, and has a valid iati-organisation/@default-currency

Expected behavior This error shouldn’t be displayed when all iati-organisation/@default-currencys are present are correct.

Screenshots Screenshot 2019-11-13 at 09 28 21

Additional context The suspected cause of this bug is outlined in data4development/IATI-Rulesets#59

rolfkleef commented 4 years ago

@andylolz we indeed need to fix this test, it's looking for iati-activity/@default-currency

rolfkleef commented 4 years ago

Fixed in IATI-Rulesets, to be deployed still.

andylolz commented 4 years ago

Great – thanks.

Would it be possible to bump this ticket when it’s deployed, so I can test? (Testing at the moment appears to show the bug is still there.)

rolfkleef commented 4 years ago

here's a ping @andylolz - the "check data" runs the latest version, the reports of existing public data will be updated when they are refreshed (github automation already closed the ticket I see)

andylolz commented 4 years ago

Ah okay, gotcha – I see. Thanks for elucidating.

the reports of existing public data will be updated when they are refreshed

When does that happen? Is it possible for me to queue or trigger it?

I see the record of when it last happened here, but not when it is scheduled to next happen: https://test-validator.iatistandard.org/organisation/pwyf

rolfkleef commented 4 years ago

Right now files are reprocessed after 48 hours (adding a trigger to reprocess when the ruleset version changes is in the backlog). Depending on the workload on the cluster it can take a while for all files to be processed (there are currently max 15 parallel machines in the test environment).

andylolz commented 4 years ago

Cool – thanks for clarifying Rolf!