search

data4development / IATI-data-validator

GNU Affero General Public License v3.0
5 stars 6 forks source link

Bug - USAID prefix not recognized as valid #47

Closed DLakin01 closed 4 years ago

DLakin01 commented 4 years ago

When checking any of our files with the new validator, we see a warning with the message that the IATI identifier given does not start with a known prefix, which appears to mean the system does not recognize "US-GOV-1" as a valid prefix. See screenshot:

image

amy-silcock commented 4 years ago

@rolfkleef 1.14.8 is a test you added recently I believe: https://data4development.atlassian.net/jira/software/projects/VAL/boards/19?selectedIssue=VAL-257

I'm in favour or removing this test as I think you're comparing reporting-orgs to http://org-id.guide/. There will be times when an identifier is correct but org-id-guide is not up to date. Or, for valid reasons we have approved an identifier which does not match org-id.guide as in the case of the US-GOV.

YohannaLoucheur commented 4 years ago

Glad to see this being discussed, as we have the same issue for our identifier CA-3, which does not conform to org-id.guide. As it is only a warning we were going to simply ignore it, but it would be preferable to remove it.

rolfkleef commented 4 years ago

To investigate... the system originally followed this hierarchy:

  1. if its an approved publisher id in the Registry, it's ok
  2. if not: if its on the organisation identifier codelist it's ok
  3. if not: if it doesn't start with an org-id prefix, provide this warning
amy-silcock commented 4 years ago

Linked to: https://github.com/data4development/IATI-data-validator/issues/50

amy-silcock commented 4 years ago

The prefix error has been resolved. This looks good to me @rolfkleef