data4development / IATI-data-validator

GNU Affero General Public License v3.0
5 stars 6 forks source link

critical error attribution #52

Closed leostolk closed 3 years ago

leostolk commented 4 years ago

Oxfam Intermon has two activity files, one smaller and one larger, the second overlaps the first completely. The larger file get a significant number (± 50?) of 1 critical error. The same activities in the smaller file do not trigger a similar critical error.

amy-silcock commented 4 years ago

Hi @stormnl,

We expect non technical users not to be able to solve schema errors in their files. We recommend they pass the purple error message on to their technical colleagues or tool provider: image

We will discuss how to word the purple critical error message better.

The data in the two files is different. The error is caused in the one file by the @secondary-reporter attribute is blank as per the purple error message: image

Also, please can Oxfam Intermon remove the duplicate activities from their reporting.

leostolk commented 4 years ago

Hi Amy

Intermon just informed me that they corrected the file and removed the duplicated activity file greetings Leo

PetyaKangalova commented 4 years ago

Hi @stormnl . Thank you for the update! Looking at both activity files, it looks like the critical errors have been fixed in your files :)

Do let me know if you think there is any improvement we can make to the messaging for that specific error? If not, I will close this issue.

leostolk commented 4 years ago
Hi PetyaLeo here, any other text would be better than the text I got from the validator.GreetingsLeo  On Wed, 11 Dec 2019, 14:09 Petya Kangalova wrote:Hi @stormnl . Thank you for the update! Looking at both activity files, it looks like the critical errors have been fixed in your files :)Do let me know if you think there is any improvement we can make to the messaging for that specific error? If not, I will close this issue.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
rolfkleef commented 4 years ago

We have this on our internal list as well to look into it as a future enhancement. It's a bit tricky to find the right format. For now, we have chosen to say: your technical person should be able to generate that schema validation output using xmllint or similar. If they're unable to do that, maybe get in touch with someone who can do schema validation ;-)

rolfkleef commented 3 years ago

closing here