search

data4development / IATI-data-validator

GNU Affero General Public License v3.0
5 stars 6 forks source link

Percentage Handling #62

Open rbesseling opened 4 years ago

rbesseling commented 4 years ago

Additional Percentage Check

Several organisations are published the "%" character in the indicator section for Measure 2-Percentage values. Could we create a message to indicate they do not need to do this and only provide the numeric value.

Missing Rule:

When percetage value is as follows (Cordaid)

Country Percentage is 100.0000%

Missing Rule:

When percentage value is as follows (Cordaid)

Sector Percentage is 50.000000% / 25.00000%

PetyaKangalova commented 4 years ago

@rbesseling here you are referring to the measure attribute. Am I correct? iati-activities/iati-activity/result/indicator/@measure

The only warning that is in the standard currently is the below.

The @value should be a valid number for all non-qualitative measures.

@rolfkleef , to look at this tomorrow.

rbesseling commented 4 years ago

Thanks Petya,

I think all Cordaid projects currently have the issue with percentage xx.000000%

http://d-portal.org/ctrack.html?publisher=NL-KVK-41160054#view=act&aid=NL-KVK-41160054-113237

The issue with adding an uneccesary % character can be seen here:

http://d-portal.org/ctrack.html?publisher=US-EIN-13-2626135#view=act&aid=US-EIN-13-2626135-BEN0003

This happens rather frequently I have seen.

R

rolfkleef commented 4 years ago

For the second example: they indeed have a % in their values. However, the rule that it should be a valid number has been added in version 2.03, and their data is using version 2.02, therefore it does not show up as feedback.