search

data61 / MP-SPDZ

Versatile framework for multi-party computation
Other
944 stars 280 forks source link

tidy output for remote execution #1455

Closed rdeviti closed 3 months ago

rdeviti commented 4 months ago

When running remote execution (with the HOSTS file) the output prints of the MPC parties are intertwined. This small change separates the output prints of each party, just because it's easier to read (or run a parser on) a tidy output.

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

mkskeller commented 4 months ago

Thank you for submitting this pull request. If I understand the code correctly, it delays outputs until the execution is finished. This is a regression for programs that take longer. Can you make it optional?

vaastav commented 4 months ago

Yes, I think we can make it optional via a flag. Do you have preferences for the flag name?

mkskeller commented 4 months ago

No, anything that's meaningful will do.

mkskeller commented 4 months ago

Thank you. As this doesn't affect pure compilation, can you make the option conditional on the execute attribute just like --hostfile?

vaastav commented 3 months ago

Please let us know if there are other changes that you would like!

mkskeller commented 3 months ago

No, this looks good now.