data61 / Mirza

6 stars 2 forks source link

As fix db option / Move tests into SupplyChain subdirectory. #148

Closed a-stacey closed 5 years ago

a-stacey commented 5 years ago

Have put two issues into this PR to simplify workflow, they are separated by commit.

Would be interested to know thoughts on using a newtype for connection string to use the type system to prevent errors using just the databasename where the connection should be used, or whether this is overkill and adds no real benefit for the "overhead" (where the overhead I mean here is expression and lines of code, not runtime performance).

Note: This changes the argument from the database connection string to the database name. Since it seems that the connection string offers no useful additional flexibility over the name, and reduces the usability (there is more chance of making an error taking the full connection string then just the name).

Note: This changes the database name command line option from -c to -d since it seems to make more sense that the database name uses d rather then the previously used c which presumably stood for connection string.

Original Author: sta358

(Moved with github-migration-0.1.0.0 (package github-migration-0.1.0.0 revision df9f38b))

a-stacey commented 5 years ago

@mas17k thanks for the feedback, have a look at the updates that I've made

Original Author: sta358