data61 / Mirza

6 stars 2 forks source link

Deduplicate common code between services #533

Open a-stacey opened 5 years ago

a-stacey commented 5 years ago

There is a lot of common code copy pasted code between services, for instance: https://github.com/data61/Mirza/blob/07ac1dc96d158e316cde0d7195718599095bebc9/projects/trails/src/Mirza/Trails/Service.hs#L59 https://github.com/data61/Mirza/blob/07ac1dc96d158e316cde0d7195718599095bebc9/projects/or_scs/src/Mirza/OrgRegistry/Service.hs#L120 that could be refactored easily and put in mirza-common-haskell to avoid the duplication. Further we could refactor the services so that they realy more on common code (and therefore unify the way things are handled). I had hoped to do this, but have not found the time.