Open unzvfu opened 6 years ago
We still need to measure just how much of the time is taken by memory copying and type conversions.
There was some further discussion on switching to array
- https://github.com/n1analytics/anonlink/pull/121#discussion_r200878288
~According to the benchmark, copying to and from the C++ library currently takes 99% of the time.~ Edit: Not true. Copying does take a lot of time in some places (see #79), but the copying mentioned below is not "99%" bad, more like "5%" bad. Really the C++ library should just be passed an address to the memory it needs to look at directly, making the copy redundant. This may take advantage of a cleaner interface to the arrays provided by a resolution to issue #64.
This issue partly supersedes issue #29 where Brian says:
The comments in issue #18 might still be relevant.
Aha! Link: https://csiro.aha.io/features/ANONLINK-68