search

data61 / stellar-random-walk

Apache License 2.0
80 stars 29 forks source link

is this a bug "bcP.value.toInt" #1

Closed yahu closed 6 years ago

yahu commented 6 years ago

at RandomWalk.scala:83 val (nextStep, _) = rSample.secondOrderSample(bcP.value.toInt, bcQ.value.toInt, prev, pNeighbors, currNeighbors)

by definition secondOrderSample(p: Float = 1.0f, q: Float = 1.0f, prevId: Int, prevNeighbors: Array[(Int, Float)], currNeighbors: Array[(Int, Float)]) p and q should be double

shps commented 6 years ago

Hi Yue,

Thanks for the bug report. Yes, that is a bug and I will fix it soon.

Cheers, Hooman