dataarts / dat.gui

Lightweight controller library for JavaScript.
Apache License 2.0
7.46k stars 1.08k forks source link

Update hide boolean when GUI hide or show #296

Open jhaemin opened 3 years ago

jhaemin commented 3 years ago

The keyboard shortcut 'h' depends on the global boolean variable hide.

Since the GUI.hide() and GUI.show() methods only update the dom's display property and not the hide boolean, the 'h' key looses its sync after calling them.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

jhaemin commented 3 years ago

@googlebot I signed it!