datguiVR initialization should be an IIFE

dataarts / dat.guiVR

A flexible graphical user interface for changing variables within WebVR.

https://workshop.chromeexperiments.com/examples/guiVR/

Apache License 2.0

311 stars 50 forks source link

datguiVR initialization should be an IIFE #54

Closed customlogic closed 7 years ago

customlogic commented 7 years ago

From our discussion in #53

datgui initialization should be an IIFE (immediately invoked function execution). This means you don't have to do DATGUIVR() anymore. However, there's a danger in doing this when using DATGUIVR as an NPM module, I'm not entirely certain. (loading order with three.js as dependency)

mflux commented 7 years ago

Partial completion. eae516e369ab99212de666c954d35d65989b47fb

The "tests" folder examples all need to be updated.

const gui =new DATGUIVR() is not required any more.

All other instances of gui.addFolder ... etc are now DATGUIVR.addFolder etc

customlogic commented 7 years ago

done in e4af9bd