search

dataarts / dat.guiVR

A flexible graphical user interface for changing variables within WebVR.
https://workshop.chromeexperiments.com/examples/guiVR/
Apache License 2.0
311 stars 50 forks source link

dat.GUIVR is clobbering dat.GUI #58

Closed customlogic closed 7 years ago

customlogic commented 7 years ago

dat.GUIVR is overwriting the dat.GUI if it's declared first. We should check if window.dat exists, and if so, append to it

customlogic commented 7 years ago

see http://localhost:8000/tests/dat-gui/double_dat.html

mflux commented 7 years ago

Should we modify dat.GUI to see if it clobbers dat.GUIVR?

mflux commented 7 years ago

Yeah I just tried it. dat.GUI clobbers dat.GUIVR as well. We'd need to update dat.GUI .

I really think branded namespaces are dumb. It really should be just datguivr if we really want it branded.

mflux commented 7 years ago

This is fixed on our end. Dat.gui needs to be updated to not clobber dat.gui VR.