search

dataarts / webgl-globe

WebGL Globe is a platform for visualizing latitude longitude based information using WebGL.
https://experiments.withgoogle.com/chrome/globe
Other
3.61k stars 1.16k forks source link

Updating various parts in globe.js and starting with prettier.js #80

Closed rscircus closed 5 years ago

mrdoob commented 5 years ago

Is this only formatting changes?

rscircus commented 5 years ago

Yes, it's prettier with tab-width of 2 spaces and otherwise defaults. I'm going to clean up the global.js a bit and started with this. :)

rscircus commented 5 years ago

Meanwhile I also started to extend the global.js already a bit, too... you can have a look at the state of things here: https://rscircus.github.io/pages/climate_anomaly/

mrdoob commented 5 years ago

I don't think you're going to have much success reformatting code in a project that has not been updated in 4 years.

rscircus commented 5 years ago

Hm, it still works quite nicely for my purpose. I started to add touch without the Swipe controls.js and the likes. Alright. I'll stay in my fork then.

rscircus commented 4 years ago

OK, a few days later, I understand your comment a bit better. I'm migrating to the most recent three.js right now... thanks for this (three.js) project. First did a move to integrate pinch-to-zoom and now wanted to dabble with VR. It's fun. :)