databacker / mysql-backup

image to enable automated backups of mysql databases in containers
648 stars 185 forks source link

$AWS_CLI_S3_CP_OPTS is not respected during backup process #205

Closed abronin closed 1 year ago

abronin commented 2 years ago

AWS_CLI_S3_CP_OPTS is just not in use when you do a backup.

Here is example of aws s3 cp command in backup restore (entrypoint file, line 118):

aws ${AWS_CLI_OPTS} ${AWS_ENDPOINT_OPT} s3 cp ${AWS_CLI_S3_CP_OPTS} "${DB_RESTORE_TARGET}" $TMPRESTORE

You can see ${AWS_CLI_S3_CP_OPTS} here.

Here is example of aws s3 cp command in backup (functions.sh file, line 220):

aws ${AWS_CLI_OPTS} ${AWS_ENDPOINT_OPT} s3 cp ${TMPDIR}/${SOURCE} "${DB_DUMP_TARGET}/${TARGET}"

(no ${AWS_CLI_S3_CP_OPTS} here).