fix docker stop after 10s

deitch commented 1 year ago

I don't mind. What does it gain us?

xiagw commented 1 year ago

Securely exit the program and save time.

deitch commented 1 year ago

I guess. Make entrypoint part of the ENTRYPOINT, please. It could be possible to add other arguments that should be passed to it

deitch commented 1 year ago

Looks fine to me. Awaiting a rebase and fixing the ENTRYPOINT/CMD

galti3r commented 1 year ago

Looks fine to me. Awaiting a rebase and fixing the ENTRYPOINT/CMD

About dumb-init There is multiple approach :

(Good solution) Manage SIGNAL traps directly inside bash program
(Good workaround solution with more features inthebox) Use dumb-init as ENTRYPOINY then load CMD command. Actual entrypoint file can be renamed run.sh for easiest understanding. Also self traps management could be a good solution to advertise any restart during dump or restore. Actually after 10s (by default), program will be killed, even if restore is processing.
(Crapy solution) change docker-compose container timeout, with stop_grace_period: 1s for example

databacker / mysql-backup