search

databacker / mysql-backup

image to enable automated backups of mysql databases in containers
648 stars 185 forks source link

remove useless if condition #227

Open xiagw opened 1 year ago

deitch commented 1 year ago

Is this a useless if statement? If the directory doesn't exist, this could return an exit code of 1, which could cause an error.

xiagw commented 1 year ago

Is this a useless if statement? If the directory doesn't exist, this could return an exit code of 1, which could cause an error.

Because "set -e" is not enabled, it will not exit on error.

deitch commented 1 year ago

True, although it should have been set. But this doesn't change anything either. Wy bother?