databacker / mysql-backup

image to enable automated backups of mysql databases in containers
648 stars 185 forks source link

RESTORE_OPTS env variable support added #228

Closed scicco closed 1 year ago

scicco commented 1 year ago

Hello,

this will address #225.

scicco commented 1 year ago

Hello, I've added a better description. For CI step, can you spot the problematic instruction in my changes that makes build fails?

deitch commented 1 year ago

Letting CI run. If it is red, we can figure it out; if green, we can merge it in.

deitch commented 1 year ago

Truly strange. Did you try running the commands locally?

scicco commented 1 year ago

Yes, no problem locally. I suspect it's related to tty. I've removed it because it's not needed to run tests

scicco commented 1 year ago

Hello @deitch, if you can approve my changes we can see if CI issue is now solved.

Thank you

deitch commented 1 year ago

Still complaining 🤷‍♂️

scicco commented 1 year ago

Ok, the previous step test_dump.sh is passed, now the problem happens inside test_restore.sh . I need to understand better where it fails. I will commit set -ex to understand which instruction fails precisely because the only error output that it's shown is related to tester database, which has six occurrences. I hope to fix everything on the next commit. Sorry to bother you again but locally I can't reproduce these issues, so I have to proceed step-by-step

Please approve again to let me debug further.

Thank you

scicco commented 1 year ago

hello @deitch, can you approve to let CI check my last commit, please? Thank you

deitch commented 1 year ago

All clean. You ready for it to go in @scicco ?

scicco commented 1 year ago

All clean. You ready for it to go in @scicco ?

Can I clean a bit my latest commit? Also do you need a squash on a single commit?

deitch commented 1 year ago

Go ahead just comment when ready.

It's easier if you squash.

scicco commented 1 year ago

Ok, done. Please check and approve to see if everything is fine now.

Thank you