database-mesh / pisanix

A Database Mesh Project Sponsored by SphereEx
https://www.pisanix.io
Apache License 2.0
281 stars 37 forks source link

Optimize(pisa-proxy, rewrite): optimize sharding_rewrite to reduce code. #370

Closed xuanyuan300 closed 2 years ago

xuanyuan300 commented 2 years ago

Signed-off-by: xuanyuan300 xuanyuan300@gmail.com

What is changed and how it works?

What's Changed:

  1. Optimize sharding_rewrite to reduce code.
codecov[bot] commented 2 years ago

Codecov Report

Merging #370 (1649fca) into master (df61eb4) will increase coverage by 7.88%. The diff coverage is 85.09%.

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   66.97%   74.86%   +7.88%     
==========================================
  Files           7        6       -1     
  Lines         427      716     +289     
==========================================
+ Hits          286      536     +250     
- Misses        133      169      +36     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 74.86% <85.09%> (+7.88%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) :arrow_down:
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 51.35% <44.11%> (-6.55%) :arrow_down:
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) :arrow_up:
pisa-controller/pkg/proxy/builder.go 94.62% <99.15%> (+3.40%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.