search

database64128 / shadowsocks-go

A versatile and efficient proxy platform for secure communications.
GNU Affero General Public License v3.0
152 stars 20 forks source link

Add an ability to get ManagedServer from Manager #43

Closed ice-dionysos closed 1 year ago

ice-dionysos commented 1 year ago

This could be useful when using shadowsocks-go as a library, and having HTTP API enabled is not possible.

database64128 commented 1 year ago

Thank you for opening this PR with carefully-written commit messages.

Unfortunately, I'm not sure if this PR should be merged in its current state. I feel like there should be better ways than simply drilling holes into existing encapsulations. Nonetheless, I understand your use case, and will keep it in mind when I make changes in the future. I'd also appreciate it if you could open an issue to discuss with me first before opening PRs like this.

ice-dionysos commented 1 year ago

Well, let's then switch to issues and see how far we can go :D https://github.com/database64128/shadowsocks-go/issues/44