database64128 / youtube-dl-wpf

A simple GUI wrapper for youtube-dl and yt-dlp.
GNU General Public License v3.0
873 stars 68 forks source link

Standard or special version of FFmpeg #130

Closed trimechee closed 2 years ago

trimechee commented 2 years ago

Hello, thank you very much for adding preset especially the worst audio preset that we can enable with a single one click and which allows us to download audio of the videos very quickly and put them in our smartphones without draining the battery or listening to tv shows when we sleep leaving the computer screen extinct !!

It's very rare exceptional to have this important preset and to be able to quickly download the worstaudio with just one click!!! thank you so much !!

just to wonder because I saw in the description "Optionally but recommended, get ffmpeg either by building from source or downloading pre-built binaries for Windows.", this takes us to the classic version of FFmpeg, but I discovered there is a special builds of FFmpeg for yt-dlp to fix some bugs,should we use this special builds of FFmpeg to fix some bugs for example :

[Fix AAC HLS streams being truncated mid stream]

[Fix for YouTube's VP9 encodes with non-monotonous DTS]

or should we use the classic version of FFmpeg ?

https://github.com/yt-dlp/FFmpeg-Builds

database64128 commented 2 years ago

I wasn't aware of the existence of yt-dlp's patched ffmpeg. From the project description it seems like it's just a fork with some patches that haven't been merged by the upstream yet. Unless you really need the features in the applied patches, it really doesn't matter what version of ffmpeg to use.

database64128 commented 2 years ago

[Fix AAC HLS streams being truncated mid stream]

[Fix for YouTube's VP9 encodes with non-monotonous DTS]

By the way, these patches you mentioned are in the historical patches section, which means they have already been upstreamed.

trimechee commented 2 years ago

Ohh if I understood correctly, the official version of FFmpeg on the official site of FFmpeg already contains these patches? Thank you very much for these clarifications :)

database64128 commented 2 years ago

Ohh if I understood correctly, the official version of FFmpeg on the official site of FFmpeg already contains these patches?

Yes.

trimechee commented 2 years ago

Great 👍