search

database64128 / youtube-dl-wpf

A simple GUI wrapper for youtube-dl and yt-dlp.
GNU General Public License v3.0
810 stars 63 forks source link

Checking Default and Auto-generated doesn't download both types of subtitltes. #201

Open FrostedVolcano opened 5 days ago

FrostedVolcano commented 5 days ago

Description: If I check both "Default" and "Auto-generated" subtitles in the subtitles section of the GUI then the default subtitle published by the creator of the video and auto generated subtitles which is generated by YouTube both should be downloaded but only the auto generated one is downloaded.

Issue: Only the auto generated subtitle is downloaded, the default one published by the creator of the video is not downloaded.

Expected result: Both types of subtitles should be downloaded and embedded into the video file. image

database64128 commented 4 days ago

Back when I implemented the feature, I opened yt-dlp/yt-dlp#826 after reading through yt-dlp/yt-dlp#630. But it looks like I forgot to implement a workaround based on https://github.com/yt-dlp/yt-dlp/issues/630#issuecomment-893659460. I'll get to it as soon as I can.

database64128 commented 2 days ago

For now, you can add --write-subs --compat-options no-keep-subs to custom arguments as a workaround.

FrostedVolcano commented 2 days ago

@database64128 thanks a lot, really appreciate your work. it shows as error: yt-dlp.exe: error: no such option: --write-subs --compat-options no-keep-subs i trid adding a - between options and no and also tried putting them in separate arguments box thing, all shows error.