databendlabs / bendsql

Databend Native Client
Apache License 2.0
49 stars 26 forks source link

bug: call `self.auth.wrap(builder)` when retry not work as what we expect. #477

Open youngsofun opened 2 months ago

youngsofun commented 2 months ago

If I understand correctly, we call it again in retry, in order to reload token from file, so it should be an overwrite of the old header value.

but the impl in reqwest is append

#[tokio::main]
async fn main() {

    let client = reqwest::Client::new();
    let mut req = client.delete("http://httpbin.org/delete")
    .header(reqwest::header::AUTHORIZATION, "password") // .basic_auth almost do the same, except is_sensitive
    .header(reqwest::header::AUTHORIZATION, "password2")
    .build().unwrap();
    println!("{:?}", req.headers());

    req.headers_mut().insert(reqwest::header::AUTHORIZATION, reqwest::header::HeaderValue::from_static("password3"));
    println!("{:?}", req.headers());
}

print:

Standard Output
{"authorization": "password", "authorization": "password2"}
{"authorization": "password3"}
youngsofun commented 2 months ago

I will fix it in next pr by the way

sundy-li commented 2 months ago

HTTP/1.1 allows header key with the same name yet HTTP/2 will duplicate the key with same name

youngsofun commented 2 months ago

HTTP/1.1 allows header key with the same name yet HTTP/2 will duplicate the key with same name

so which one will be kept? the first or the last?

sundy-li commented 2 months ago

so which one will be kept? the first or the last? I don't know, maybe we should add function in reqwest to override the header.