Closed Maricaya closed 1 week ago
Please remove the "✨" in the title.
The contributor is from the Summer of Open Source Promotion Plan. Please help with the review when it is ready. @PsiACE @zhang2014 @everpcpc
Please resolve the conflict first @Maricaya
@sundy-li Request to merge into the main branch, thanks!
@sundy-li Request to merge into the main branch, thanks!
do we need to wait for another pr in databend?
@Maricaya please add frontend/**
to licenserc.toml to fix the license check.
@sundy-li Request to merge into the main branch, thanks!
do we need to wait for another pr in databend?
@Maricaya please add
frontend/**
to licenserc.toml to fix the license check.
Let's wait for the databend pr to merge into the main branch
@sundy-li Request to merge into the main branch, thanks!
do we need to wait for another pr in databend? @Maricaya please add
frontend/**
to licenserc.toml to fix the license check.Let's wait for the databend pr to merge into the main branch
got it!
@sundy-li This PR https://github.com/databendlabs/databend/pull/16543 is already in the main branch.
@sundy-li this PR is ready, would you mind merging it?
@Maricaya Ok, It will be merged after ci pass.
please commit after you check it in local:
cargo fmt --all -- --check
typos
..
@Maricaya Thanks for the contribution.
Some comments about this pr.
I checked the codes and looks like it will start a new server to listen to a free port in each graphical query
, this may cause too much port resource usage.
is_repl
is true?graphical query
in is_repl
mode, we can generate a random URL to render the data for this query. cool, glad to see this project has landed, thanks @Maricaya @Chasen-Zhang @sundy-li
@Maricaya Thanks for the contribution.
Some comments about this pr.
I checked the codes and looks like it will start a new server to listen to a free port in each
graphical query
, this may cause too much port resource usage.
- Can we start a dedicated HTTP server as a service if it's
is_repl
is true?- If we receive
graphical query
inis_repl
mode, we can generate a random URL to render the data for this query.
Got it, thanks for the feedback. Let me finish the CI process first. Here's the PR: https://github.com/databendlabs/bendsql/pull/486. I'll let you know once it's ready.
explain analyze graphical
command to visualize SQL performance analysis.https://github.com/user-attachments/assets/fe276f03-a176-43a2-9b9a-8097201dda12