Closed sundy-li closed 2 weeks ago
Why not use set_var to do it?
LGTM
Maybe add a new type in SetType is better than HintItem?
pub enum SetType {
#[default]
SettingsSession,
SettingsGlobal,
Variable,
SettingsQuery,
}
And if user use query level settings and hints , the hints will be invalid.
That's easy to delete the code about hints.
Summary
syntax
SETTINGS clause works only in Statement of:
examples:
We already had
set_var_hints
now, but the syntax is not friendly. Settings could also be parsed intoHintItem
.Any advice? cc @zhang2014 @andylokandy
Refer to https://docs.yellowbrick.com/6.8.1/ybd_sqlref/setting_clause.html