databendlabs / databend

๐——๐—ฎ๐˜๐—ฎ, ๐—”๐—ป๐—ฎ๐—น๐˜†๐˜๐—ถ๐—ฐ๐˜€ & ๐—”๐—œ. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com
https://docs.databend.com
Other
7.85k stars 750 forks source link

refactor: simplify vacuum drop table handling #16446

Closed drmingdrmer closed 2 months ago

drmingdrmer commented 2 months ago

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: simplify vacuum drop table handling

Tests

Type of change

Related Issues


This change isโ€‚Reviewable

SkyFan2002 commented 2 months ago

Would you like to add some documentation comments to the functions get_drop_table_infos(), do_get_table_history(),get_gc_table_info(),batch_filter_table_info()? which would make it more friendly to read.@drmingdrmer

drmingdrmer commented 2 months ago

Would you like to add some documentation comments to the functions get_drop_table_infos(), do_get_table_history(),get_gc_table_info(),batch_filter_table_info()? which would make it more friendly to read.@drmingdrmer

Yes I will do so, comment is always very important for teamwork. but I still don't fully understand how it works yet. :(