fix(query): use custom connector for udf client

databendlabs / databend

𝗗𝗮𝘁𝗮, 𝗔𝗻𝗮𝗹𝘆𝘁𝗶𝗰𝘀 & 𝗔𝗜. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com

https://docs.databend.com

Other

7.85k stars 750 forks source link

fix(query): use custom connector for udf client #16697

Closed everpcpc closed 2 weeks ago

everpcpc commented 2 weeks ago

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

enable SO_REUSEADDR for udf client
use global dns resolver

Tests

[x] Unit Test
[ ] Logic Test
[ ] Benchmark Test
[ ] No Test - Explain why

Type of change

[x] Bug Fix (non-breaking change which fixes an issue)
[ ] New Feature (non-breaking change which adds functionality)
[ ] Breaking Change (fix or feature that could cause existing functionality not to work as expected)
[ ] Documentation Update
[ ] Refactoring
[ ] Performance Improvement
[ ] Other (please describe):

This change is

sundy-li commented 2 weeks ago

ok, please check that #16696 may also use this client construct function

everpcpc commented 2 weeks ago

As commented, please don't merge.

I thinks there's no need to block this PR.

Hyper 0.14 is already pulled by FlightServiceClient with tonic 0.11, and this PR dose not introduce any new usage on it.
After upgrading arrow-rs to 0.53 and tonic 0.12, hyper 0.14 would be gone eventually.
DNS issue is a little urgent problem for udf client. If upgrading for arrow-rs has a long way to go, we can't wait for it.

cc @Xuanwo

Xuanwo commented 2 weeks ago

After upgrading arrow-rs to 0.53 and tonic 0.12, hyper 0.14 would be gone eventually.

Yes, already working on this. This PR can be based on that PR instead.

PR will land in later one hour.

Xuanwo commented 2 weeks ago

Hi, apologies for blocking you @everpcpc here, but the upcoming PR is quite large and has already taken me a full day. If possible, I'd really prefer for this PR to happen afterward.

everpcpc commented 2 weeks ago

PTAL cc @Xuanwo