databendlabs / databend

๐——๐—ฎ๐˜๐—ฎ, ๐—”๐—ป๐—ฎ๐—น๐˜†๐˜๐—ถ๐—ฐ๐˜€ & ๐—”๐—œ. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com
https://docs.databend.com
Other
7.88k stars 751 forks source link

fix: clustering_information panic if string domain is none #16792

Closed zhyass closed 2 weeks ago

zhyass commented 2 weeks ago

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The cause of this panic is that the default domain maximum for String types is NULL. Therefore, wrapping the String type in a Nullable is necessary to handle this correctly.

Tests

Type of change


This change isโ€‚Reviewable

dantengsky commented 2 weeks ago

@zhyass

LGTM, besides: seems you are using a different version of py code formatter black ?