search

databendlabs / databend

𝗗𝗮𝘁𝗮, 𝗔𝗻𝗮𝗹𝘆𝘁𝗶𝗰𝘀 & 𝗔𝗜. Modern alternative to Snowflake. Cost-effective and simple for massive-scale analytics. https://databend.com
https://docs.databend.com
Other
7.84k stars 750 forks source link

databend-meta: removing a member should be done with metactl, instead of with the server binary. #7179

Open drmingdrmer opened 2 years ago

drmingdrmer commented 2 years ago

E.g.:

databend-metactl --leave id --leave-via addr1 addr2...
flaneur2020 commented 2 years ago

is --leave-via necessary ? q.q

how the other metactl commands interacts with the cluster?

drmingdrmer commented 2 years ago

is --leave-via necessary ? q.q

Yes... metactl itself does not know any info about a cluster.

how the other metactl commands interacts with the cluster?

Exporting is done via grpc port.

flaneur2020 commented 2 years ago

how about make the discovery parameter a more general like --endpoints or --cluster?

if we add a join command, introducing another --join-via might be duplicated.

in etcdctl there's a --endpoints parameter, it's required by almost every subcommand.

https://etcd.io/docs/v3.5/tutorials/how-to-deal-with-membership/

drmingdrmer commented 2 years ago

how about make the discovery parameter a more general like --endpoints or --cluster?

if we add a join command, introducing another --join-via might be duplicated.

in etcdctl there's a --endpoints parameter, it's required by almost every subcommand.

https://etcd.io/docs/v3.5/tutorials/how-to-deal-with-membership/

Looks good