search

databio / bbconf

Configuration package for bedbase project
https://pypi.org/project/bbconf/
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

es search default number of hits returned #3

Closed joseverdezoto closed 4 years ago

joseverdezoto commented 4 years ago

@stolarczyk I completely forgot a small but important detail. If I recall correctly the bbconf search_bedfiles function is a wrapper of es.search() right? The problem is that this function defaults the number of returned hits to 10, regardless of how many files exist in a certain index. So as of now if we had hundreds of file in the bedfiles index, bedbuncher would only process 10.

It might be a really easy fix, es.search() has the argument size (default:10) which allows you to define the number of desired returned hits. https://elasticsearch-py.readthedocs.io/en/master/api.html

stolarczyk commented 4 years ago

I made it return all the hits on dev branch last week. I’ll probs make a release tomorrow, so use the dev version for now

stolarczyk commented 4 years ago

000f5fcf44bc124a87affbd90552da5ca22dce08

joseverdezoto commented 4 years ago

Gotcha!