Sentence transformer update to fastembed?

databio / bbconf

Configuration package for bedbase project

https://pypi.org/project/bbconf/

BSD 2-Clause "Simplified" License

1 stars 2 forks source link

Sentence transformer update to fastembed? #35

Closed nsheff closed 6 months ago

nsheff commented 7 months ago

File "/usr/local/lib/python3.11/site-packages/bbconf/bbconf.py", line 49, in <module>
    from sentence_transformers import SentenceTransformer
ModuleNotFoundError: No module named 'sentence_transformers'

But in fact, it appears that geniml is no longer using SentenceTransformer.

@ClaudeHu, can you update these two lines to accommodate the new way of using the text2bednn in your dev geniml branch?

nsheff commented 7 months ago

@nleroy917 should it be possible then to have bbconf not require torch?

how will we organize this?

khoroshevskyi commented 6 months ago

@ClaudeHu I think this is Geniml issue, am I correct? If yes, please, transfer this issue to geniml

ClaudeHu commented 6 months ago

@ClaudeHu I think this is Geniml issue, am I correct? If yes, please, transfer this issue to geniml

Not completely a geniml issue. geniml had an update (replace SentenceTransformers by fastembed) and code here was not adjusted. Now bbconf/bbconf.py has been adjusted for that refactor.

khoroshevskyi commented 6 months ago

@ClaudeHu what do you think, how long will it take to finish this issue? Can you take the lead on this issue, and when it will be solved write it here?

khoroshevskyi commented 6 months ago

This issue was fixed by @ClaudeHu